Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] fieldservice: Search by name. #1270

Open
wants to merge 2 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][FIX] fieldservice: Search by name. #1270

wants to merge 2 commits into from

Conversation

DorianMAG
Copy link

Remove str method in xml search filter_domain

@OCA-git-bot
Copy link
Contributor

Hi @brian10048, @max3903,
some modules you are maintaining are being modified, check this out!

@DorianMAG DorianMAG mentioned this pull request Nov 27, 2024
Open
@DorianMAG DorianMAG changed the title [17.0][FIX] Fieldservice: Search by name. [17.0][FIX] fieldservice: Search by name. Nov 27, 2024
@DorianMAG
[FIX] fieldservice: Search by name.
cb36421 
Remove str method in xml search filter_domain
@DorianMAG DorianMAG force-pushed the 17.0-fix-fieldservice-search_by_name branch from d96032c to cb36421 Compare November 27, 2024 11:18
@max3903 max3903 added this to the 17.0 milestone Nov 27, 2024
@max3903 max3903 self-assigned this Nov 27, 2024
flotho
flotho suggested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if I undestand the syntxa, I thinks it's useless
IMHO ('name', 'ilike', self ) should be enough
could you please give you POV @ilo @max3903 ?
Regards

flotho
flotho approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @max3903 approve I have no technical comments on this one

ivantodorovich
ivantodorovich approved these changes Nov 28, 2024
View reviewed changes
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @flotho , that leaf seems useless and could be removed IMO.
In any case, the explicit str casting wasn't needed neither

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max3903 max3903 max3903 approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@flotho flotho flotho approved these changes

Assignees

@max3903 max3903

Labels
approved bug needs review ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@DorianMAG @OCA-git-bot @max3903 @flotho @ivantodorovich