[14.0] report_xlsx: Fix currency format #957
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some xlsx readers doesn't like mixed formats on the same column.
Here we sometimes have the sign on the left, sometimes on the right.
(change introduced in this commit on
account-financial-report
OCA/account-financial-reporting@f088aa6#diff-8237378723eb85bb5c6d6e16f339b55840b762029442371284fe1ad71d08c1e2When it happens, we get
###
displayed (even though value is ok)-> No, this isn't because of the column being too narrow.
Among the tested readers, I was able to reproduce on
excel
(asking to repair the file),onlyoffice
(not proposing any fix) andgsheet
.Reverting to a simple number format.
Also, the only report on which this method is
open items
inaccount_financial_report
, which also displays the currency in a dedicated column. This information is redundant.