[16.0][FIX] stock_picking_return_restricted_qty: remove _onchange_quantity method #1799
+2
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ced-adhoc
force-pushed
the
16.0-t-85239-ced
branch
from
12ac81a to
8398544
Compare
mav-adhoc
approved these changes
Dec 19, 2024
rousseldenis
requested changes
Dec 20, 2024
| qty = self.get_returned_restricted_quantity(self.move_id) | ||
|
|
||
| if restrict_return_qty and self.quantity > qty: | ||
| raise UserError(_("Return more quantities than delivered is not allowed.")) |
There was a problem hiding this comment.
@ced-adhoc You remove here a fucntionality. Maybe in order to get user warned before validating the return should be to add an alert on the wizard form (if it is possible) or by other mean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this fix to remove the _onchange_quantity method because when changing the quantity on the return wizard to a greater quantity than the original and clicking on the return button, it first validate the _onchange_quantity method and, due to the user error, changes back the quantity to the original one and then it runs the _create_returns method with the original quantity. This causes that if the user made a mistake and wanted to return less quantity than the original one, they cannot correct it since the return is already created.
With this fix, after clicking on the return button, it validates the quantities and when closing the user error popup window it remains on the return wizard allowing to correct the returned quantity.