Migrate ocrd v3 #216
Open
Migrate ocrd v3 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- separate `setup` / `_init` from processing - inherit/override `_init` - init Tesseract API once, keep as class attribute - define `process_page_pcgts` instead of `process`: - no input file loop - no METS action - just return tuples for derived images - move shared utility functions into `common` module - generate etree mapping by exporting PAGE model
kba
reviewed
Aug 11, 2024
ocrd_tesserocr/binarize.py
Outdated
|
|
||
| def process(self): | ||
| def process_page_pcgts(self, pcgts, output_file_id=None, page_id=None): |
There was a problem hiding this comment.
Besides missing the typing, this has a different signature, pcgts is not variadic here. Python allows this and it is convenient but I am wondering whether it would be better to be consistent with the typing and signature?
Suggested change
| def process_page_pcgts(self, pcgts, output_file_id=None, page_id=None): | |
| def process_page_pcgts(self, *input_pcgts, output_file_id : Optional[str] = None, page_id : Optional[str] = None) -> OcrdPage: | |
| pcgts = input_pcgts[0] |
There was a problem hiding this comment.
Typing – sure, I was just to lazy again.
Variadic – I thought it would be clearer like that. So we would not have to do any arity checking in the function itself – a type checker could simply detect invalid use cases which do pass multiple pages at once. But perhaps I am wrong. (Also, we already have the arity assertion in setup.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on OCR-D/core#1240 (i.e.
ocrd>=3.0).