Fix Handling of Higher-Order Functions #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current OCaml-Solidity parser does not properly handle the use of higher-order functions. For example, given this code:
it returns the following error:
Type error: Invalid type for argument in "function call". Invalid implicit conversion from "function(int256) nonpayable " to "function(int256) nonpayable " requested
. This is because it doesn't realize that apublic
function is an acceptable substitute for theinternal
function expected as a parameter tohof
.This PR fixes this issue (and other similar type conversion issues) with higher-order functions by implementing the allowed conversions for function types and mutabilities; it also includes several test cases to exercise the functionality.