Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bin_area to the inversion flowlines #1744

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

fmaussion
Copy link
Member

@bearecinos @dngoldberg this adds the bin_area attribute to the inversion flowlines objects. It's just a handy diagnostic, its also possible to compute it from the previous objects attribues, as is done in the code here.

Copy link
Member

@bearecinos bearecinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! that will be what we need ... this means that we will have to start from a lower pre-processing level right? maybe L1-L2 ?
and re-compute some prepro levels tasks
Cheers!

@fmaussion
Copy link
Member Author

this means that we will have to start from a lower pre-processing level right?

No you won't have to. Your workflow simply starts from existing OGGM inversion and model flowlines and then overwrites them. I suggest to start from Level 3 and then redo the whole inversion to model flowline tasks. As explained in this tutorial: https://tutorials.oggm.org/stable/notebooks/tutorials/building_the_prepro_gdirs.html#level-3

# This should calibrate FSM instead
workflow.execute_entity_task(tasks.mb_calibration_from_geodetic_mb,
                             gdirs,
                             informed_threestep=True,  # only available for 'GSWP3_W5E5'
                            );

# glacier bed inversion
workflow.execute_entity_task(tasks.apparent_mb_from_any_mb, gdirs);
workflow.calibrate_inversion_from_consensus(
    gdirs,
    apply_fs_on_mismatch=True,
    error_on_mismatch=True,  # if you running many glaciers some might not work
    filter_inversion_output=True,  # this partly filters the overdeepening due to
    # the equilibrium assumption for retreating glaciers (see. Figure 5 of Maussion et al. 2019)
    volume_m3_reference=None,  # here you could provide your own total volume estimate in m3
);

# finally create the dynamic flowlines
workflow.execute_entity_task(tasks.init_present_time_glacier, gdirs);

@fmaussion fmaussion merged commit 3ec3cb0 into OGGM:master Sep 16, 2024
26 of 27 checks passed
@bearecinos
Copy link
Member

awesome 🥳 thanks @fmaussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants