Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing tests on #464. Tests are failing because the DEATH measurePersonCompleteness check is now marked
Yes
in the updated threshold files, and as such the new sqlOnly output includes SQL queries for the DEATH check. To fix the failing tests the expected SQL queries needed to be updated, as did the expected number of inserted results table rows.I ended up refactoring the SQL query output tests to use testthat snapshots instead of the previous approach of comparing to static SQL files, which made debugging failures hard/impossible. Snapshots allow us to view a nice diff of actual vs expected results when we run tests locally. I needed to upgrade to testthat edition 3 to access the snapshots feature, and as a result I also included a few other refactors related to the edition 3 upgrade.