resolve cran feedback

.Rbuildignore

@@ -10,3 +10,4 @@ _pkgdown.yml
 cran-comments.md
 ^CRAN-RELEASE$
 work/*
+^CRAN-SUBMISSION$

CRAN-SUBMISSION

@@ -0,0 +1,3 @@
+Version: 2.0.0
+Date: 2024-04-16 20:03:15 UTC
+SHA: 53f57cba7a55b79e60ec84baea9399f4ae19743c

DESCRIPTION

@@ -1,8 +1,8 @@
 Package: Eunomia
 Type: Package
-Title: Standard Dataset Manager for OMOP CDM Sample Datasets
+Title: Standard Dataset Manager for Observational Medical Outcomes Partnership Common Data Model Sample Datasets
 Version: 2.0.0
-Date: 2024-04-16
+Date: 2024-04-22
 Authors@R: c(
   person("Frank", "DeFalco", , "fdefalco@ohdsi.org", role = c("aut", "cre")),
   person("Martijn", "Schuemie", , "schuemie@ohdsi.org", role = c("aut")),
@@ -13,7 +13,7 @@ Authors@R: c(
   person("Observational Health Data Science and Informatics", role = c("cph"))
   )
 Maintainer: Frank DeFalco <fdefalco@ohdsi.org>
-Description: Facilitates access to sample datasets from the EunomiaDatasets repository (<https://github.com/ohdsi/EunomiaDatasets>).
+Description: Facilitates access to sample datasets from the 'EunomiaDatasets' repository (<https://github.com/ohdsi/EunomiaDatasets>).
 License: Apache License 2.0
 URL: https://github.com/OHDSI/Eunomia
 BugReports: https://github.com/OHDSI/Eunomia/issues
@@ -29,7 +29,6 @@ Suggests:
   withr,
   duckdb,
   DatabaseConnector
-Remotes: OHDSI/CommonDataModel
 Encoding: UTF-8
 LazyData: true
 RoxygenNote: 7.3.1

R/Connection.R

@@ -139,7 +139,7 @@ getDatabaseFile <- function(datasetName,
   }
 
   if (!datasetAvailable && !archiveAvailable) {
-    writeLines(paste("attempting to download", datasetName))
+    message(paste("attempting to download", datasetName))
     downloadedData <- downloadEunomiaData(datasetName = datasetName, cdmVersion = cdmVersion, pathToData = pathToData, verbose=verbose)
     if (verbose) {
       message("downloaded: ",downloadedData,appendLF = TRUE)

R/EunomiaData.R

@@ -70,6 +70,7 @@ downloadEunomiaData <- function(datasetName,
 #' @param cdmVersion The version of the OMOP CDM that are represented in the archive files.
 #' @param inputFormat The format of the files expected in the archive. (csv or parquet)
 #' @param verbose Provide additional logging details during execution.
+#' @returns No return value, called to load archive into a database file.
 #' @importFrom tools file_ext
 #' @examples
 #' \dontrun{
@@ -111,6 +112,7 @@ extractLoadData <- function(from, to, dbms = "sqlite",cdmVersion="5.3", inputFor
 #' @param cdmDatabaseSchema The schema in which to create the CDM tables. Default is main.
 #' @param verbose        Provide additional logging details during execution.
 #' @param overwrite      Remove and replace an existing data set.
+#' @returns No return value, loads data into database file.
 #' @export
 loadDataFiles <- function(dataPath,
                       dbPath,
@@ -239,6 +241,7 @@ loadDataFiles <- function(dataPath,
 #' @param dbms           The file-based database system to use: 'sqlite' (default) or 'duckdb'
 #' @param outputFormat    The output format for the files.  Supported formats include csv, parquet.
 #' @param verbose       Boolean argument controlling verbose debugging output
+#' @returns No return value, called to export to outputFolder.
 #' @export
 exportDataFiles <- function(dbPath, outputFolder, outputFormat="csv", dbms = "sqlite", verbose=FALSE) {
   stopifnot(outputFormat %in% c("csv","parquet"))

cran-comments.md

@@ -1,4 +1,5 @@
 Release of 2.0 version of package.
+Resolved CRAN feedback issues
 
 ---