Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote from BLAIS5-3953 to main #122

Merged
merged 24 commits into from
Nov 30, 2023
Merged

Promote from BLAIS5-3953 to main #122

merged 24 commits into from
Nov 30, 2023

Conversation

social-surveys-blaise-concourse

Auto generated by concourse:

Promote from BLAIS5-3953 to main

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6c1d98) 99.48% compared to head (41d5f87) 99.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   99.48%   99.51%   +0.02%     
==========================================
  Files          61       63       +2     
  Lines        1550     1637      +87     
==========================================
+ Hits         1542     1629      +87     
  Misses          8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elthorne elthorne marked this pull request as ready for review November 30, 2023 14:56
@elthorne
Copy link
Contributor

This PR includes:

  • Targeted links to Data Delivery, NISRA, and BTS playbooks for corresponding Slack alerts
  • Silences all sandbox alerts except Training
  • Refactoring of some typos and unused imports

just to see if it works 👀

refs: BLAIS5-3593
this should be easier to read

refs: BLAIS5-3953
refs: BLAIS5-3953
refs: BLAIS5-3953
lib/filters/sandbox_filter.py Outdated Show resolved Hide resolved
tests/lib/filters/test_sandbox_filter.py Show resolved Hide resolved
as "private" as Python functions can be 👀

refs: BLAIS5-3953
@elthorne elthorne merged commit 420a238 into main Nov 30, 2023
7 checks passed
@elthorne elthorne deleted the BLAIS5-3953 branch November 30, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants