RAS-1378 Fix datetime deprecation warning on party service #448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Delegates the created_on time retrieval to the built in database method (which saves it in UTC without timezone information - as we have been doing with datetime anyway). This solves the issue we were seeing with using the "new"
datetime.now(UTC)
function replacing the deprecateddatetime.utcnow()
function, which was using the time checked at app startup in the models and not evaluating on each column creation. The instances in the pending survey deletion cron job are evaluated on each request and therefore work as they should.How to test?
pending_surveys
tablekubectl edit deployments party
and edit theEMAIL_TOKEN_EXPIRY
to a more reasonable number from 3 daysJira
RAS-1378