Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAS-1400 Extend party enrolment to include business and survey details #449

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

LJBabbage
Copy link
Contributor

@LJBabbage LJBabbage commented Dec 17, 2024

What and why?

This PR updates the enrolment information endpoint, instead of just posting busines_ids and survey_ids it provides all the bits that are needed. It also adds a new endpoint just to checkout enrolment

How to test?

Deploy this card as well ONSdigital/ras-frontstage#1016. Add some enrolment data to your account, acceptance tests could be used, but you might want to add another IAC as well. If it logs in you are good. Also check you can access a eq, download and upload a seft. Equally you can just call the endpoints on this service

N.B there is a chart addition so you will need to deploy this via helm or provide the survey_url env. (i.e helm install party ./_infra/helm/party) don't forget if you already have a party service deployed via spinnaker you will need to kill the current deployments, service etc

kubectl delete service party --namespace <your namespace>
kubectl delete cronjob party-scheduler-delete-respondents --namespace <your namespace>
kubectl delete cronjob party-scheduler-remove-expired-pending-surveys --namespace <your namespace>
kubectl delete externalsecret party --namespace <your namespace>

@LJBabbage LJBabbage requested a review from a team as a code owner December 17, 2024 10:29
Copy link
Contributor

@matthew-robinson-ons matthew-robinson-ons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions properly, no issues with the suggested code changes

@SteveScorfield
Copy link
Contributor

/deploy scorfs

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: scorfs

  • tag: pr-449

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

Copy link
Contributor

@SteveScorfield SteveScorfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine and tests all okay. Approved

@LJBabbage LJBabbage merged commit 73a0cce into main Dec 19, 2024
1 check passed
@LJBabbage LJBabbage deleted the extend-enrolment-details branch December 19, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants