-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAS-1400 Extend party enrolment to include business and survey details #449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functions properly, no issues with the suggested code changes
/deploy scorfs |
Deploying to dev cluster with following parameters:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine and tests all okay. Approved
What and why?
This PR updates the enrolment information endpoint, instead of just posting busines_ids and survey_ids it provides all the bits that are needed. It also adds a new endpoint just to checkout enrolment
How to test?
Deploy this card as well ONSdigital/ras-frontstage#1016. Add some enrolment data to your account, acceptance tests could be used, but you might want to add another IAC as well. If it logs in you are good. Also check you can access a eq, download and upload a seft. Equally you can just call the endpoints on this service
N.B there is a chart addition so you will need to deploy this via helm or provide the survey_url env. (i.e helm install party ./_infra/helm/party) don't forget if you already have a party service deployed via spinnaker you will need to kill the current deployments, service etc