Dictionary Benchmarks #2705
Draft
Dictionary Benchmarks #2705
+684
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2705 +/- ##
==========================================
- Coverage 54.67% 54.64% -0.03%
==========================================
Files 349 349
Lines 65694 65694
Branches 13440 13440
==========================================
- Hits 35918 35901 -17
- Misses 25882 25902 +20
+ Partials 3894 3891 -3 ☔ View full report in Codecov by Sentry. |
mregen
commented
Aug 10, 2024
|
|
||
| /// <summary> | ||
| /// Tests performance and memory usage of ImmutableDictionary. | ||
| /// </summary> |
mregen
commented
Aug 10, 2024
| public abstract class DictionaryKeyBenchmark<T> | ||
| { | ||
| // [Params(16, 128, 1024)] | ||
| public int NumElements { get; set; } = 1024; |
There was a problem hiding this comment.
re add size parameter
mregen
commented
Aug 10, 2024
| public int NumElements { get; set; } = 1024; | ||
|
|
||
| // Create a Dictionary and a SortedDictionary | ||
| protected T[] m_lookup = null; |
mregen
commented
Aug 10, 2024
|
|
||
| /// <summary> | ||
| /// Tests performance and memory usage of SortedDictionary. | ||
| /// </summary> |
Bumps [BenchmarkDotNet](https://github.com/dotnet/BenchmarkDotNet) from 0.13.12 to 0.14.0. - [Release notes](https://github.com/dotnet/BenchmarkDotNet/releases) - [Commits](dotnet/BenchmarkDotNet@v0.13.12...v0.14.0) --- updated-dependencies: - dependency-name: BenchmarkDotNet dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…-0.14.0' into dictbenchmarks
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Dictionary<NodeId,value>Related Issues
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NodeId Dictionary Benchmarks: For each IdType, last one is with mixed NodeId.