Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse compositional summary keywords #3516

Merged
merged 1 commit into from
May 11, 2023

Conversation

goncalvesmachadoc
Copy link
Contributor

I can run OPM/opm-tests#959 using this implementation.
It parses: "WXMF", "WYMF", "WZMF", "WCGMR", "WCOMR" , but does not output anything.

@goncalvesmachadoc
Copy link
Contributor Author

jenkins build this please

Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, but as you say won't actually internalise any of the nodes or output any values to the summary file. Are those tasks intended as follow-up work here, or are we aiming for a minimum support level of "don't stop the run if we encounter these summary keywords"?

@goncalvesmachadoc
Copy link
Contributor Author

This PR intention is just to avoid stopping the run for the benchmark cases.

Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the knowledge that this is primarily a stop-gap measure to avoid crashing when running cases featuring these summary keywords I'll merge this. We'll develop actual support for calculating and outputting the values to the summary file as need arises.

@bska bska merged commit 910cd4c into OPM:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants