feat(storage): add redis storage #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EladBezalel
reviewed
Jul 23, 2019
server/CompositeStorage/lib/index.ts
Outdated
| Maybe | ||
| } from '@dynamico/driver'; | ||
|
|
||
| export class CompositeStorage implements Storage { |
There was a problem hiding this comment.
I think it's a composition storage
Suggested change
| export class CompositeStorage implements Storage { | |
| export class CompositionStorage implements Storage { |
EladBezalel
reviewed
Jul 23, 2019
server/CompositeStorage/lib/index.ts
Outdated
| ComponentTree, | ||
| ComponentGetter, | ||
| Maybe | ||
| } from '@dynamico/driver'; |
There was a problem hiding this comment.
Why are we getting these types out of the driver and not the common types?
There was a problem hiding this comment.
Yeah it's kind of weird... Not sure what's the correct structure here is but I wanted some package to export the types and not publish a @types/dynamico package. I'll play with it some more to find the best setup...
EladBezalel
reviewed
Jul 23, 2019
| saveComponent(component: Component, files: File[]): Promise<void>; | ||
| } | ||
|
|
||
| export type Storage = IndexStorage & ComponentsStorage; |
eladav
force-pushed
the
add-redis-storage
branch
4 times, most recently
from
e196187
to
61a5229
Compare
eladav
changed the title
eladav
force-pushed
the
add-redis-storage
branch
3 times, most recently
from
c866ba6
to
e21d4f3
Compare
* re-organize types * add composite storage * tests for redis storage and composition storage
EladBezalel
force-pushed
the
add-redis-storage
branch
from
e21d4f3
to
6a949f6
Compare
EladBezalel
approved these changes
Aug 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves redis storage and a way to composite storages #48 and Common types should be exported from a shared package #17