Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSWH + CWE #436

Closed
wants to merge 2 commits into from
Closed

CSWH + CWE #436

wants to merge 2 commits into from

Conversation

drwetter
Copy link

@drwetter drwetter commented Dec 16, 2024

  • Add term CSWH for the exploit (usefult for searching --> couldn't find anything here)
  • Add reference to CWE

Contributions should only be made in the proper repo against the latest content. Please don't open PRs here for versioned or stable content, they represent point-in-time state.

Which branch would be that? At github I could only find v4.2

- Add term CSWH for the exploit
- Add reference to CWE
@kingthorin
Copy link
Collaborator

kingthorin commented Dec 16, 2024

Contributions
Any contributions to the guide itself should be made via the guide’s project repo.

🛑 Contributions should only be made in the proper repo against the latest content. Please don’t open PRs here for versioned or stable content, they represent point-in-time state.


Also the acronym doesn't appear to match the name/title you've provided.

@kingthorin kingthorin closed this Dec 16, 2024
@drwetter
Copy link
Author

Any contributions to the guide itself should be made via the guide’s project repo

Ah, ok. thanks.

Please update the PR template then. It's not transparent, especially if you're coming from the web site which invites you to click on the github link. proper repo needs to be explained.

Also the acronym doesn't appear to match the name/title you've provided.

?

CSWH is in the title and in the content.

@drwetter
Copy link
Author

drwetter commented Dec 16, 2024

One last thing, this an off topic: The links should be updated to https where possible in this and other repos:

https://github.com/search?q=repo%3AOWASP%2Fwww-project-web-security-testing-guide+http%3A%2F%2F&type=code

Probably that can be automated somehow like when curl hits a 30x and a location header with https, https should be fine.

@kingthorin
Copy link
Collaborator

I'll definitely tweak the template. Seems the comment workflow is busted too.

Is it just me or doesn't CWSH make more sense than CSWH?

If it's cross origin websocket hijacking then what's the S in CSWH.... at least the other way it's the S in WebSocket....

Ummm unless it's Cross site Websocket Hijacking???

@kingthorin
Copy link
Collaborator

We don't update any of the versioned content, it's as-is at time of tag/release.

I believe everything (or awfully close) in "latest" should be using https. (There may be examples that haven't been updated but actual links should have been.)

@drwetter
Copy link
Author

drwetter commented Dec 16, 2024

Most used nowadays is CSWH . Cross-Site !

@kingthorin
Copy link
Collaborator

Okay, if you’re going to resubmit on the other repo then please use that vs cross origin

@kingthorin kingthorin reopened this Dec 16, 2024
@drwetter
Copy link
Author

We don't update any of the versioned content, it's as-is at time of tag/release

Up to you, YMMV. But looking at the offending links (you have a lot like attackers/victims etc. which I am not referring to) I feel ashamed.

@drwetter
Copy link
Author

PR on the other site comes tomorrow morning CET

@kingthorin kingthorin closed this Dec 16, 2024
@kingthorin
Copy link
Collaborator

@kingthorin
Copy link
Collaborator

….it doesn’t render as markdown though. I’ll see if I came make it more clear somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants