Skip to content

Commit

Permalink
ESDEV-4666 Add /modules/ to exclude-pattern
Browse files Browse the repository at this point in the history 
Modules should run their own coding standards tests
  • Loading branch information
@robertblank
robertblank committed Jul 18, 2017
1 parent f83870c commit 2b0305a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Oxid/ruleset.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<exclude-pattern>/config.inc.php</exclude-pattern>
<exclude-pattern>/vendor/</exclude-pattern>
<exclude-pattern>/tests/</exclude-pattern>
<exclude-pattern>/modules/</exclude-pattern>

This comment has been minimized.

Sign in to view

Copy link
@ddpkts

ddpkts May 25, 2018

hey @robertblank I think this is not a good idea, coz excluding module dir prevents running phpcsoxid against my own modules in the project

This comment has been minimized.

Sign in to view

Copy link
@ddpkts

ddpkts May 28, 2018

@Sieg @MantasVaitkunas @BenjaminJoerger just want to escalate this a bit :) Imagine I am developing a project with my own custom modules and I can not run phpcsoxid against these modules, because modules dir is excluded. Dirty solutions: downgrade to v3.0.2 or fork and customize my own stadards, but I don't like going dirty way

This comment has been minimized.

Sign in to view

Copy link
@MantasVaitkunas

MantasVaitkunas May 28, 2018

Contributor

Hi @ddpkts, looks like you are right, but first of all I would like to double check with @robertblank. He will be present next week.

This comment has been minimized.

Sign in to view

Copy link
@robertblank

robertblank Jun 6, 2018

Author Contributor

@ddpkts You are right. I did not think in this use case and will revert this commit

<!-- Include specific sniffs from the other standards. -->
<rule ref="Generic.Metrics.CyclomaticComplexity"/>
Expand Down

0 comments on commit 2b0305a

Please sign in to comment.