Merge pull request #276 from OXID-eSales/UNZER-394_clean_up_tmporder_…

…table_oxid_7

UNZER-394 Clean up tmporder table

CHANGELOG.md

@@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### NEW
 - provide content for smarty and twig
-- If a customer interrupt the order in the checkout for any reason, the order is still saved using a temporary order and Unzer's webhook
+- If a customer interrupt the order in the checkout for any reason, the order is still saved using a temporary order and Unzer's webhook + scheduled cleanup temporary order
 - Save Payment Data for registered Users
 
 ### FIXED

src/Controller/DispatcherController.php

@@ -15,6 +15,7 @@
 use OxidEsales\Eshop\Core\Exception\DatabaseErrorException;
 use OxidEsales\Eshop\Core\Registry;
 use OxidEsales\Eshop\Core\Request;
+use OxidEsales\EshopCommunity\Internal\Framework\Database\QueryBuilderFactoryInterface;
 use OxidSolutionCatalysts\Unzer\Service\Transaction;
 use OxidSolutionCatalysts\Unzer\Service\Translator;
 use OxidSolutionCatalysts\Unzer\Service\UnzerSDKLoader;
@@ -23,6 +24,9 @@
 use UnzerSDK\Constants\PaymentState;
 use UnzerSDK\Exceptions\UnzerApiException;
 
+/**
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class DispatcherController extends FrontendController
 {
     use ServiceContainer;
@@ -137,6 +141,29 @@ public function updatePaymentTransStatus(): void
             }
         }
 
+        $this->cleanUpTmpOrder();
         Registry::getUtils()->showMessageAndExit($result);
     }
+
+    /**
+     * @return void
+     * @throws \Doctrine\DBAL\Exception
+     */
+    private function cleanUpTmpOrder()
+    {
+        /** @var QueryBuilderFactoryInterface $queryBuilderFactory */
+        $queryBuilderFactory = $this->getServiceFromContainer(QueryBuilderFactoryInterface::class);
+
+        $queryBuilder = $queryBuilderFactory->create();
+
+        $query = $queryBuilder
+            ->delete('oscunzertmporder')
+            ->where('timestamp < :timestamp');
+
+        $parameters = [
+            ':timestamp' => date("Y-m-d H:i:s", ( time() - ( 60 * 60 * 24 ) ))
+        ];
+
+        $query->setParameters($parameters)->execute();
+    }
 }

tests/PhpStan/phpstan.neon

@@ -1,9 +1,10 @@
 parameters:
-    checkMissingIterableValueType: false
     treatPhpDocTypesAsCertain: false
     bootstrapFiles:
         - phpstan-bootstrap.php
     level: max
     scanFiles:
         - ../../vendor/oxid-esales/oxideshop-ce/source/oxfunctions.php
-        - ../../vendor/oxid-esales/oxideshop-ce/source/overridablefunctions.php
+        - ../../vendor/oxid-esales/oxideshop-ce/source/overridablefunctions.php
+    ignoreErrors:
+        - identifier: missingType.iterableValue