Adopt OctoLight #1229
Merged
Adopt OctoLight #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated octolight plugin details
- Updated OctoLight images
- Added note about OctoLight - changing maintainer
- Added note about OctoLight
- Corrected date mistake in the octolight.md file
jneilliii
reviewed
Sep 16, 2023
- Corrected authors - Corrected image path
|
Thank you regarding the point about the logs, I will go ahead and update the code shortly :) |
jneilliii
approved these changes
Sep 16, 2023
|
Is it possible to add another Event option to have the light go on when a filament change occurs? |
|
Hey @ArtSpaziano, Submit an issue on my repo and I can look into it, we can discuss it more there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New maintainer of OctoLight
Closes: #1225
An issue was created on the original OctoLight repo to check if it was abandoned. I showed interest in maintaining this plugin, @gigibu5 was happy for me to take over.
gigibu5/OctoLight#41
Please let me know if I have done anything incorrectly or need to update anything else.