check who is dead at the start of meetings and don't let them talk at… #369
Conversation
… the end of a meeting
| } | ||
| } | ||
| return [...prevState]; | ||
| }); |
There was a problem hiding this comment.
I might be missing something but couldn't you use the above otherDead variable? It appears to be set at the time time and to the same values.
| } | ||
| if (checkIfPlayerWasDeadAtStartOfMeeting(myPlayer.ptr) && !myPlayer.isDead) { | ||
| myPlayer.isDead = true; | ||
| } |
There was a problem hiding this comment.
Could be refactored out of the loop as we don't need to check the local players dead state for every other player.
| // bug with TOH where all players are considered alive during the ejection screen. This is a workaround | ||
| if (checkIfPlayerWasDeadAtStartOfMeeting(player.ptr) && !player.isDead) { | ||
| player.isDead = true; | ||
| } |
There was a problem hiding this comment.
O(n^2), this is what lead me to look for other ways to do it and found the otherDead variable previously mentioned. It uses an indexed type so instead of iterating the entire player list for every player you can directly look it up. I know the performance difference is probably negligible but it should be slightly faster to use a look up type and I believe this is ran for basically every frame of the game.
|
Download the artifacts for this pull request:
This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time. |
… the end of a meeting
There is a bug with that latest version of TOH. During the ejection screen all ghosts have their isDead status set to false, causing alive players to hear the ghosts and potentially spoiling who the impostor is.
The fix is a simple array of player id's, at the start of each meeting it checks who is dead, then makes sure they're not able to speak during the ejection screen.
If a mod has reviving, the fix in the pr shouldn't affect it, only if they can be revived during a meeting. From what I found from googling the only mod with reviving does so during the TASK gamestate so this fix shouldn't affect it.