[wpmlbridge-301] Unsync documents on non indexable stati. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decodekult
force-pushed
the
wpmlbridge-301
branch
from
7da10c5 to
1f06714
Compare
| return; | ||
| } | ||
|
|
||
| $indexablePostStati = $postIndexable->get_indexable_post_status(); |
There was a problem hiding this comment.
Suggested change
| $indexablePostStati = $postIndexable->get_indexable_post_status(); | |
| $indexablePostStatus = $postIndexable->get_indexable_post_status(); |
There was a problem hiding this comment.
there is also Stati in the commit so I don't know if it's a typo or intentional :)
everything else is great 👍
There was a problem hiding this comment.
I understand stati is the plural form of status (as opposed to statuses which doesn't really exist). I saw it here:
https://developer.wordpress.org/reference/functions/get_post_stati/
|
+1 @decodekult |
- Unsync documents with a status not supported by their indexes. #49
decodekult
force-pushed
the
wpmlbridge-301
branch
from
1f06714 to
1a8bb75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#49