Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name with dot before extension #59

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

btriller
Copy link
Contributor

@btriller btriller commented Oct 17, 2024

Description

Jira Issue

Is this PR for Development?

  • Yes, this PR is for the development branch.
  • No, this PR targets a different branch (please specify):

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Test Cases

  • Test cases are covered for this PR.
  • This PR does not require test cases (please explain):

Checklist

  • I have performed a self-review of my own code.
  • I have linked all related Jira issues.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if applicable).
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Additional Information

e.g. https://github.com/netbox-community/devicetype-library/blob/master/module-types/Cisco/PWR-1.6KW-AC.yaml is listed as PWR-1

@abhi1693
Copy link
Contributor

@btriller can you share examples for making this change? We need to document this in our jira before we can accept it

@btriller
Copy link
Contributor Author

@btriller can you share examples for making this change? We need to document this in our jira before we can accept it

I'm using https://github.com/netbox-community/devicetype-library as source and w/o this change e.g. both fiber modules from [1] are missing .D-PC-ceramic-C-2-black in import view. Imported module types have correct names though (see attached images).

image image

[1] https://github.com/netbox-community/devicetype-library/tree/master/module-types/Reichle%20%26%20De-Massari

@abhi1693 abhi1693 merged commit 7babb23 into Onemind-Services-LLC:master Oct 18, 2024
3 of 4 checks passed
@btriller btriller deleted the fix-name-dot branch October 18, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants