[VT]: Add a way to track VT float attributes #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad3154
added
enhancement
ad3154
force-pushed
the
adrian/vt-float-attributes
branch
from
351e3a4 to
38a6923
Compare
This lets you use the VT state helper to deal with float attributes. Previously, float values may not have been handled correctly.
ad3154
force-pushed
the
adrian/vt-float-attributes
branch
from
38a6923 to
4c83485
Compare
|
GwnDaan
reviewed
Nov 8, 2024
Comment on lines
+77
to
+87
| /// @brief Sets the value of a float attribute of a tracked object. | ||
| /// @attention ONLY use this function for float attributes defined in ISO11783-6, | ||
| /// otherwise you will get incorrect results. Scale on output numbers, for example, is a float. | ||
| /// @note If the to be tracked working set consists of more than the master, | ||
| /// this function is incompatible with a VT prior to version 4. For working sets consisting | ||
| /// of only the master, this function is compatible with any VT version. | ||
| /// @param[in] objectId The object id of the attribute to set. | ||
| /// @param[in] attribute The attribute to set. | ||
| /// @param[in] value The value to set the attribute to. | ||
| /// @return True if the attribute was set successfully, false otherwise. | ||
| bool set_attribute(std::uint16_t objectId, std::uint8_t attribute, float value); |
There was a problem hiding this comment.
thought: hmm, seems a lot of duplication that we might be able to avoid? With your current implementation we leave the conversion from float value to uint32_t all the way up to the VT client. What if we instead do it in this function directly? And then call the neighbor helper set_attribute function instead
There was a problem hiding this comment.
Hmmm good idea I think, that does sound appealing. I can rework it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This lets you use the VT state helper to deal with float attributes. Previously, float values were probably not handled correctly.
I was seeing that there were warnings in the seeder example about this:
How has this been tested?