Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: add guards for errno values for ARMCC compiler #271

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

ldaj00
Copy link
Contributor

@ldaj00 ldaj00 commented Oct 24, 2023

The new guards prevent redefinition of errno values which have already been defined in the standard libraries.

Copy link
Contributor

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Please, could you rebase on on top af main branch that fixes the CI issue.

Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@arnopo
Copy link
Contributor

arnopo commented Nov 2, 2023

@ldaj00
The Merge branch 'OpenAMP:main' into armcc-errno-guards commit should not be part of the PR, please force your armcc-errno-guards branch to be on to of the main branch lib: add guards for errno values for ARMCC compiler commit

@arnopo
Copy link
Contributor

arnopo commented Nov 2, 2023

In addition, as ARMCC compiler user, could give feedback on #270?
Thanks in advance.

The new guards prevent redefinition of errno values which have already
been defined in the standard libraries.

Signed-off-by: Ledion Daja <ledion.daja@arm.com>
@ldaj00
Copy link
Contributor Author

ldaj00 commented Nov 3, 2023

@arnopo Thanks for catching the merge commit. It should be fixed now.

could give feedback on #270?

Ack, will do.

@arnopo arnopo merged commit 8041e1c into OpenAMP:main Nov 6, 2023
4 checks passed
@arnopo arnopo added this to the Release V2024.04 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants