ExternalInflow: rename files, change names in files #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the OpenFOAM module name to ExternalInflow.
deslaughter
approved these changes
Jul 14, 2023
deslaughter
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the OpenFOAM module name to ExternalInflow.
This PR is ready to merge.
Feature or improvement description
Many years ago, OpenFAST was linked to SOWFA through the code OpenFOAM. The module in OpenFAST that linked to OpenFOAM was also called OpenFOAM.
However, now multiple CFD codes, including SOWFA, NALU-Wind, and AMR-Wind, provide wind information to OpenFAST. Thus the OpenFOAM module name no longer makes sense as the OpenFOAM software package is not the only code used. So the OpenFOAM module in OpenFAST is changing names to the more descriptive name of ExtInflow.
Related issue, if one exists
Cancelled PR #1450
Impacted areas of the software
The CFD codes that use OpenFAST will need to change the names of the routines they call.
Additional supporting information
Module short name changed from OpFM to ExtInfw (this is only used within the OpenFAST code).
Test results, if applicable
No test results change, but the input files have a minor change for the CompInflow line.