Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📄🔧:update adr 0004 w/ fine example usage #691

Merged

Conversation

DerekNonGeneric
Copy link
Member

@DerekNonGeneric DerekNonGeneric commented Jan 30, 2024

Pull Request Purpose

Make a selection on the purpose(s) of your changes.

This PR contains the following:

  • 🐞🔧 bugfixing (🐜/🦟/🐛/🦗/🐝 et al.)
  • 🆕🎏 implementation of new feature(s)
  • ♻️ refactoring(s)
  • 📄 documentation modification(s)
  • 🔮 other

Testing

Have you included any tests in your submission?

  • yes (bugfixes and features will not be merged without
    tests
    )
  • no

Breaking Changes

Have you modified any aspect public API surface (i.e., caused breakage)?

  • yes (breaking changes will not be merged unless
    necessary
    )
  • no

Description

A concise recap summarily detailing what all are the changes being made.

Maybe having more concrete example usage would be helpful in understanding proper expected usage…

List of any relevant issue numbers:

@DerekNonGeneric DerekNonGeneric requested review from OpenINFbot and a team January 30, 2024 22:38
@DerekNonGeneric DerekNonGeneric added linting Issues and PRs that deal with linting markdown An issue or PR related to Markdown 🏗️ Category: Infrastructure/Tooling/Builds/CI undefined labels Jan 30, 2024
@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Jan 30, 2024

Since the JS/TS linting situation is currently quite tumultuous (ESLint vs. Biome)12; let's start w/ Markdown linting first when thinking in terms of custom lint rules…

🔗 https://www.npmjs.com/package/remark-lint
🔗 https://www.npmjs.com/package/markdownlint-cli2

Footnotes

  1. https://twitter.com/biomejs/status/1738089211742269492

  2. https://twitter.com/biomejs/status/1738089211742269492

@DerekNonGeneric
Copy link
Member Author

Right, if you thought custom Babel plugins should be mentioned as acceptable use, correct!

Extending that privilege to source code of plugins supporting Markdown transformation, also correct!

Signed-off-by: Derek Lewis <dereknongeneric@open.inf.is>
we can list it on the members roster!
this probably helps determine staleness
@OpenINFbot OpenINFbot added the fast-track PRs that do not need to wait for 48 hours to land label Jan 31, 2024
Co-authored-by: OpenINF Bot <132791922+openinfbot@users.noreply.github.com>
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
@DerekNonGeneric

This comment was marked as resolved.

DerekNonGeneric and others added 5 commits January 31, 2024 02:11
Signed-off-by: Derek Lewis <dereknongeneric@open.inf.is>
we can list it on the members roster!
this probably helps determine staleness
Co-authored-by: OpenINF Bot <132791922+openinfbot@users.noreply.github.com>
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
DerekNonGeneric and others added 3 commits January 31, 2024 02:38
roster will give her back her version
Co-authored-by: Derek Lewis <dereknongeneric@open.inf.is>
Signed-off-by: OpenINF Bot <132791922+openinfbot@users.noreply.github.com>
Signed-off-by: OpenINF Bot <132791922+openinfbot@users.noreply.github.com>
Signed-off-by: OpenINF Bot <132791922+openinfbot@users.noreply.github.com>
Signed-off-by: OpenINF Bot <132791922+openinfbot@users.noreply.github.com>
Copy link
Member

@OpenINFbot OpenINFbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these additions/modifications are fine.

@DerekNonGeneric DerekNonGeneric added the author-ready PRs that are considered ready by their author label Jan 31, 2024
@OpenINFbot OpenINFbot merged commit 0ff3aad into OpenINF:main Jan 31, 2024
4 checks passed
@DerekNonGeneric DerekNonGeneric deleted the amend/adr-004--custom-lint-rules branch January 31, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-ready PRs that are considered ready by their author 🏗️ Category: Infrastructure/Tooling/Builds/CI undefined 🚨 Category: Tests undefined fast-track PRs that do not need to wait for 48 hours to land infrastructure investigating linting Issues and PRs that deal with linting markdown An issue or PR related to Markdown tools Issues and PRs related to the tools directory 🔔 Type: New undefined
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants