Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale service roles at cardinality changes #554

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Scale service roles at cardinality changes #554

merged 1 commit into from
Oct 17, 2024

Conversation

sk4zuzu
Copy link
Collaborator

@sk4zuzu sk4zuzu commented May 30, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

This PR adds missing OneFlow service role scaling implemented in the simplest way currently possible (imo).

References

#553

New or Affected Resource(s)

  • opennebula_service

Checklist

  • I have created an issue and I have mentioned it in References
  • My code follows the style guidelines of this project (use go fmt)
  • My changes generate no new warnings or errors
  • I have updated the unit tests and they pass succesfuly
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (if needed)
  • I have updated the changelog file

@sk4zuzu sk4zuzu requested a review from treywelsh May 30, 2024 05:14
@sk4zuzu sk4zuzu changed the title F #553: Scale service roles at cardinality changes Scale service roles at cardinality changes May 30, 2024
@sk4zuzu sk4zuzu marked this pull request as draft May 30, 2024 06:20
@sk4zuzu sk4zuzu removed the request for review from treywelsh May 30, 2024 06:20
@sk4zuzu sk4zuzu force-pushed the f-553 branch 6 times, most recently from 5001d94 to dbbaa99 Compare June 3, 2024 13:25
@sk4zuzu sk4zuzu marked this pull request as ready for review June 3, 2024 14:28
@sk4zuzu sk4zuzu requested a review from treywelsh June 3, 2024 14:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

@github-actions github-actions bot closed this Jul 9, 2024
@treywelsh treywelsh reopened this Aug 8, 2024
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

@sk4zuzu
F #553: Scale service roles at cardinality changes
084898c 
The role scale feature is currently supported in OpenNebula >= 6.8.0,
please refer to OpenNebula/one#5591.
@dgarcia18 dgarcia18 self-assigned this Oct 16, 2024
@dgarcia18
Copy link
Contributor

LGTM, tests pass and manual testing successful, merging

@dgarcia18 dgarcia18 merged commit 5d936fe into master Oct 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treywelsh treywelsh Awaiting requested review from treywelsh

Assignees

@dgarcia18 dgarcia18

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sk4zuzu @dgarcia18 @treywelsh