Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pass custom config to validator #3184

Closed

Conversation

effigies
Copy link
Contributor

@effigies effigies commented Oct 25, 2024

In prep to migrate to the schema validator, we need to promote some warnings to errors.

Reminded that we need to do this by bids-standard/bids-specification#1928, which proposes to downgrade SUBJECT_FOLDERS from an error to a warning. I don't think OpenNeuro wants to downgrade that, so this preemptively pegs it as an error.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 44.06%. Comparing base (1c1e0d3) to head (10877ad).
Report is 47 commits behind head on master.

Files with missing lines Patch % Lines
...openneuro-app/src/scripts/workers/schema.worker.ts 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3184      +/-   ##
==========================================
+ Coverage   43.10%   44.06%   +0.95%     
==========================================
  Files         547      547              
  Lines       36178    36192      +14     
  Branches     1128     1162      +34     
==========================================
+ Hits        15595    15947     +352     
+ Misses      20383    20056     -327     
+ Partials      200      189      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Contributor Author

xref https://github.com/bids-standard/bids-validator/pull/2176, since that's needed to support microscopy blacklisting properly.

@nellh
Copy link
Contributor

nellh commented Nov 12, 2024

Included in #3206

@nellh nellh closed this Nov 12, 2024
@effigies effigies deleted the feat/configure-validator branch November 12, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants