Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object price so $15 is refunded upon removal - Update object.json #346

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

astraylife1
Copy link
Contributor

Fix object price so $15 is refunded upon removal

Fix deletion price to refund money
@astraylife1 astraylife1 changed the title Update object.json Fix object price so $15 is refunded upon removal - Update object.json Aug 31, 2024
@@ -9,7 +9,7 @@
"objectType": "scenery_small",
"properties": {
"price": 20,
"removalPrice": 0,
"removalPrice": 15,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not seem to have tested this (or compared with the other base blocks). I suggest you do, it will make the error quite apparent ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know how to test the object. How do I download it from my fork? I don’t know how to put the json with the day since on my Mac it has to split the parkobj to be able to access the json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, just take a look at one of the other base blocks, specifically their removalPrice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience and understanding. This is a big learning curve for me with no coding/github experience. I think I got it fixed now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I very deliberately challenged you.

@Gymnasiast Gymnasiast merged commit 763b479 into OpenRCT2:master Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants