Add object with original game peep names #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
AaronVanGeffen
force-pushed
the
guest-names-obj
branch
2 times, most recently
from
af3cef2
to
6e1a5c5
Compare
tupaschoal
reviewed
Sep 13, 2024
|
Hmm, I honestly think we shouldn't try to 'translate' names at an object level. Personally, I'd like to have, say, a set of Spanish names as a separate object to tie them to particular scenarios, regardless of what interface language is being used. |
AaronVanGeffen
changed the title
My point was not that we should try to translate, but whether we would be able to easily plug another language name set in, and make it more "immersive" for people not playing in English. |
Gymnasiast
reviewed
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.