Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update PSF scicookie report #12

Merged
merged 8 commits into from
Jul 3, 2024
Merged

docs: update PSF scicookie report #12

merged 8 commits into from
Jul 3, 2024

Conversation

EverVino
Copy link
Contributor

No description provided.

@EverVino
Copy link
Contributor Author

@xmnlab ready for a review

Copy link
Contributor

@Anavelyz Anavelyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EverVino I left some suggestions

scicookie/psf-grant-report-2024-01.md Outdated Show resolved Hide resolved
scicookie/psf-grant-report-2024-01.md Outdated Show resolved Hide resolved
scicookie/psf-grant-report-2024-01.md Outdated Show resolved Hide resolved
EverVino and others added 3 commits July 2, 2024 18:42
Co-authored-by: Anavelyz Perez <42752529+Anavelyz@users.noreply.github.com>
Co-authored-by: Anavelyz Perez <42752529+Anavelyz@users.noreply.github.com>
Co-authored-by: Anavelyz Perez <42752529+Anavelyz@users.noreply.github.com>
@EverVino
Copy link
Contributor Author

EverVino commented Jul 2, 2024

Thanks @Anavelyz. Nice suggestions

@EverVino
Copy link
Contributor Author

EverVino commented Jul 2, 2024

@xmnlab ready for a final review

not fit into its package scope either, despite this we make sure to comply
with the quality requirements (tests, CI configuration, documentation), we
have also initiated communications with
[Leah Wasser](https://github.com/lwasser), CEO of pyOpenSci, who has directly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better to change from CEO to Executive Director .. my impression is that CEO is used more for companies

Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added a small comment here.
other than that, it looks good to me

@EverVino
Copy link
Contributor Author

EverVino commented Jul 3, 2024

just added a small comment here. other than that, it looks good to me

Thanks @xmnlab. Fixing that and merging

@EverVino EverVino merged commit bdb3c02 into main Jul 3, 2024
1 check passed
@xmnlab xmnlab deleted the update-final-report branch July 3, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants