Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: Add astx to the makim proposal #15

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented Aug 12, 2024

No description provided.

@xmnlab
Copy link
Member Author

xmnlab commented Aug 12, 2024

@apkrelling @abhijeetSaroha @investor-uyah

when you have time could you review this proposal please?

@EverVino do you want to act as project manager in this project?

@xmnlab
Copy link
Member Author

xmnlab commented Aug 12, 2024

just this file is important for this review: https://github.com/OpenScienceLabs/grant-proposals/pull/15/files#diff-6169f44d43179b521a323aad64d5ec4cd59505c3ed8cd461896a51a31a2dd62cR1

the other changes are basically changes in the folder's organization

@abhijeetSaroha
Copy link
Contributor

@xmnlab , I've reviewed the proposal, and everything looks good to me!

@apkrelling
Copy link

LGTM as well 🙂

@investor-uyah
Copy link

investor-uyah commented Aug 12, 2024 via email

@xmnlab
Copy link
Member Author

xmnlab commented Aug 13, 2024

thanks @abhijeetSaroha @apkrelling @investor-uyah for the review, appreciate that.

@xmnlab xmnlab merged commit 1b194d1 into OpenScienceLabs:main Aug 13, 2024
1 check passed
@xmnlab xmnlab deleted the update-makim-proposal branch August 13, 2024 00:03
@EverVino
Copy link
Contributor

Hello @xmnlab , thanks for the offer, but these months I'm going to be tight on my schedule, I won't be able to this time.

@xmnlab
Copy link
Member Author

xmnlab commented Aug 13, 2024

@EverVino, thanks for the response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants