Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] build_dpdk.sh - git am command path fix #1007

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MateuszGrabuszynski
Copy link

The git am command does use a path which drills down too little (does not hit the patches folder) and fails the script entirely.

Copy link
Collaborator

@skolelis skolelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MateuszGrabuszynski
Copy link
Author

One remark from @skolelis was raised - this is dependent on the directory from which the script is executed. My intention is to always execute from the same exact directory (./build-dpdk ...), and I have not found the script used/sourced anywhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants