Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests to generic runtime #382

Merged
merged 11 commits into from
Dec 19, 2024
Merged

Add unit tests to generic runtime #382

merged 11 commits into from
Dec 19, 2024

Conversation

KitHat
Copy link
Member

@KitHat KitHat commented Dec 13, 2024 •
edited
Loading

Task list:

  • asset config tests
  • lib tests
  • types tests
  • origins tests

PR Checklist

  • Tests

@KitHat KitHat requested a review from 4meta5 December 13, 2024 18:48
@KitHat KitHat self-assigned this Dec 13, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 13, 2024 •
edited
Loading

✅ Deploy Preview for docs-oz-polkadot canceled.

Name Link
🔨 Latest commit 9ad86f2
🔍 Latest deploy log https://app.netlify.com/sites/docs-oz-polkadot/deploys/67634a126293c30008f2c249

4meta5
4meta5 reviewed Dec 14, 2024
View reviewed changes
Copy link
Contributor

@4meta5 4meta5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good! How much has coverage increased?

@KitHat
Copy link
Member Author

KitHat commented Dec 16, 2024

Tests look good! How much has coverage increased?

It raised to 47%

@4meta5 4meta5 mentioned this pull request Dec 17, 2024
Closed
3 tasks
4meta5
4meta5 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@4meta5 4meta5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only had a few comments, will there be a follow up issue to add similar tests to the evm-template or will those be included in this PR ?

@KitHat
Copy link
Member Author

KitHat commented Dec 18, 2024

Looks good, only had a few comments, will there be a follow up issue to add similar tests to the evm-template or will those be included in this PR ?

I think I will make one more PR for the EVM. This one is getting too big

@KitHat KitHat merged commit 76340e9 into main Dec 19, 2024
7 checks passed
@KitHat KitHat deleted the nikita-unit-tests branch December 19, 2024 11:46
@4meta5 4meta5 changed the title Add unit tests Add unit tests to generic runtime Dec 19, 2024
@4meta5 4meta5 mentioned this pull request Dec 19, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4meta5 4meta5 4meta5 approved these changes

Assignees

@KitHat KitHat

Labels
None yet
Projects
Substrate Runtime Templates
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KitHat @4meta5