-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Roles Abstraction and clean up Users module #17088
Open
MikeAlhayek
wants to merge
11
commits into
main
Choose a base branch
from
ma/roles-abstractions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
force-pushed
the
ma/roles-abstractions
branch
from
November 27, 2024 22:12
9d71fca
to
1c3cf78
Compare
This pull request has merge conflicts. Please resolve those before requesting a review. |
MikeAlhayek
added
the
breaking change 💥
Issues or pull requests that introduces breaking change(s)
label
Nov 28, 2024
MikeAlhayek
commented
Nov 30, 2024
src/OrchardCore/OrchardCore.Roles.Abstractions/OrchardCore.Roles.Abstractions.csproj
Outdated
Show resolved
Hide resolved
…es.Abstractions.csproj
This pull request has merge conflicts. Please resolve those before requesting a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new Roles.Abstractions project and moved all of the roles abstraction to it. Also, moved all of the roles services into Core.Roles.