Merge pull request #1294 from Ordisoftware/dev

Dev
Ordisoftware · Mar 27, 2023 · 5ee50b2 · 5ee50b2
2 parents 383d867 + 7d8b244
commit 5ee50b2
Show file tree

Hide file tree

Showing 28 changed files with 32 additions and 31 deletions.
diff --git a/Project/Dependencies/CultureManager/CultureManager.cs b/Project/Dependencies/CultureManager/CultureManager.cs
@@ -613,7 +613,7 @@ protected virtual bool IsExcluded(string componentName, string propertyName)
       string resourceName = $"{componentName}.{propertyName}";
       foreach ( string value in _excludeProperties )
       {
-        if ( value.IndexOf('.') >= 0 )
+        if ( value.Contains('.') )
         {
           if ( resourceName.Contains(value) ) return true;
         }

diff --git a/Project/Hebrew Calendar (vs2022).csproj b/Project/Hebrew Calendar (vs2022).csproj
@@ -1210,7 +1210,7 @@
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
     <PackageReference Include="Meziantou.Analyzer">
-      <Version>2.0.20</Version>
+      <Version>2.0.26</Version>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>

diff --git a/Project/Source/Common/Core/WinForms/EditMemoForm.cs b/Project/Source/Common/Core/WinForms/EditMemoForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-04 </edited>
 namespace Ordisoftware.Core;
 
-public partial class EditMemoForm : Form
+public sealed partial class EditMemoForm : Form
 {
 
   static public readonly Point LocationZero;

diff --git a/Project/Source/Common/Core/WinForms/HTMLBrowserForm.cs b/Project/Source/Common/Core/WinForms/HTMLBrowserForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-05 </edited>
 namespace Ordisoftware.Core;
 
-public partial class HTMLBrowserForm : Form
+public sealed partial class HTMLBrowserForm : Form
 {
 
   private readonly string LocationPropertyName;

diff --git a/Project/Source/Common/Core/WinForms/InputBox.cs b/Project/Source/Common/Core/WinForms/InputBox.cs
@@ -17,7 +17,7 @@ namespace Ordisoftware.Core;
 /// <summary>
 /// Provides input box.
 /// </summary>
-public partial class InputBox<T> : Form
+public sealed partial class InputBox<T> : Form
 where T : IConvertible
 {
 

diff --git a/Project/Source/Common/Core/WinForms/MessageBoxEx.cs b/Project/Source/Common/Core/WinForms/MessageBoxEx.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-06 </edited>
 namespace Ordisoftware.Core;
 
-public partial class MessageBoxEx : Form
+public sealed partial class MessageBoxEx : Form
 {
 
   public const bool DefaultJustifyEnabled = true;

diff --git a/Project/Source/Common/Core/WinForms/ShowTextForm.cs b/Project/Source/Common/Core/WinForms/ShowTextForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2020-11 </edited>
 namespace Ordisoftware.Core;
 
-public partial class ShowTextForm : Form
+public sealed partial class ShowTextForm : Form
 {
 
   private readonly bool HideOnClose;

diff --git a/Project/Source/Common/Core/WinForms/TraceForm.cs b/Project/Source/Common/Core/WinForms/TraceForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-03 </edited>
 namespace Ordisoftware.Core;
 
-public partial class TraceForm : Form
+public sealed partial class TraceForm : Form
 {
 
   private readonly string LocationPropertyName;
@@ -154,8 +154,8 @@ private void ActionRefreshFiles_Click(object sender, EventArgs e)
       else
       {
         var content = File.ReadAllText(file);
-        string strError = $"{LogTraceEvent.Error} {DebugManager.EventSeparator}";
-        string strException = $"{LogTraceEvent.Exception} {DebugManager.EventSeparator}";
+        string strError = $"{nameof(LogTraceEvent.Error)} {DebugManager.EventSeparator}";
+        string strException = $"{nameof(LogTraceEvent.Exception)} {DebugManager.EventSeparator}";
         if ( content.IndexOf(strError, StringComparison.OrdinalIgnoreCase) >= 0
           || content.IndexOf(strException, StringComparison.OrdinalIgnoreCase) >= 0 )
           SelectFile.Items.Add(file);

diff --git a/Project/Source/Common/Hebrew/WinForms/CelebrationVersesBoardForm.cs b/Project/Source/Common/Hebrew/WinForms/CelebrationVersesBoardForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-11 </edited>
 namespace Ordisoftware.Hebrew;
 
-public partial class CelebrationVersesBoardForm : Form
+sealed public partial class CelebrationVersesBoardForm : Form
 {
 
   private const float FontFactor = 1.5f;

diff --git a/Project/Source/Forms/Boxes/Boards/LunarMonthsForm.CreateControls.cs b/Project/Source/Forms/Boxes/Boards/LunarMonthsForm.CreateControls.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-03 </edited>
 namespace Ordisoftware.Hebrew.Calendar;
 
-sealed partial class LunarMonthsForm : Form
+partial class LunarMonthsForm : Form
 {
 
   [SuppressMessage("IDisposableAnalyzers.Correctness", "IDISP001:Dispose created", Justification = "<En attente>")]

diff --git a/Project/Source/Forms/Boxes/Boards/LunarMonthsForm.cs b/Project/Source/Forms/Boxes/Boards/LunarMonthsForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-04 </edited>
 namespace Ordisoftware.Hebrew.Calendar;
 
-partial class LunarMonthsForm : Form
+sealed partial class LunarMonthsForm : Form
 {
 
   static private readonly Properties.Settings Settings = Program.Settings;

diff --git a/Project/Source/Forms/Boxes/Boards/NextCelebrationsForm.cs b/Project/Source/Forms/Boxes/Boards/NextCelebrationsForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-11 </edited>
 namespace Ordisoftware.Hebrew.Calendar;
 
-partial class NextCelebrationsForm : Form
+sealed partial class NextCelebrationsForm : Form
 {
 
   static public NextCelebrationsForm Instance { get; private set; }

diff --git a/Project/Source/Forms/Boxes/Boards/ParashotForm.cs b/Project/Source/Forms/Boxes/Boards/ParashotForm.cs
@@ -19,7 +19,7 @@ namespace Ordisoftware.Hebrew;
 using MainForm = Calendar.MainForm;
 using System.Windows.Forms;
 
-partial class ParashotForm : Form
+sealed partial class ParashotForm : Form
 {
 
   static public ParashotForm Instance { get; private set; }

diff --git a/Project/Source/Forms/Boxes/Reminder/ReminderForm.cs b/Project/Source/Forms/Boxes/Reminder/ReminderForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-11 </edited>
 namespace Ordisoftware.Hebrew.Calendar;
 
-partial class ReminderForm : Form
+sealed partial class ReminderForm : Form
 {
 
   #region Static Constructor and Run

diff --git a/Project/Source/Forms/Boxes/Reminder/ReminderForm.resx b/Project/Source/Forms/Boxes/Reminder/ReminderForm.resx
@@ -223,7 +223,7 @@
     <value>Flat</value>
   </data>
   <data name="ActionClose.Location" type="System.Drawing.Point, System.Drawing">
-    <value>344, 115</value>
+    <value>344, 125</value>
   </data>
   <data name="ActionClose.Size" type="System.Drawing.Size, System.Drawing">
     <value>40, 26</value>
@@ -600,7 +600,7 @@
     <value>Parashot board</value>
   </data>
   <data name="ContextMenuParashah.Size" type="System.Drawing.Size, System.Drawing">
-    <value>211, 176</value>
+    <value>211, 154</value>
   </data>
   <data name="&gt;&gt;ContextMenuParashah.Name" xml:space="preserve">
     <value>ContextMenuParashah</value>
@@ -767,7 +767,7 @@
     <value>6, 13</value>
   </data>
   <data name="$this.ClientSize" type="System.Drawing.Size, System.Drawing">
-    <value>384, 141</value>
+    <value>384, 151</value>
   </data>
   <data name="$this.Padding" type="System.Windows.Forms.Padding, System.Windows.Forms">
     <value>10, 10, 10, 10</value>

diff --git a/Project/Source/Forms/Boxes/Reminder/SelectSuspendDelayForm.cs b/Project/Source/Forms/Boxes/Reminder/SelectSuspendDelayForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2021-04 </edited>
 namespace Ordisoftware.Hebrew.Calendar;
 
-partial class SelectSuspendDelayForm : Form
+sealed partial class SelectSuspendDelayForm : Form
 {
 
   static private readonly Properties.Settings Settings = Program.Settings;

diff --git a/Project/Source/Forms/Boxes/Search/SearchEventForm.cs b/Project/Source/Forms/Boxes/Search/SearchEventForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2021-05 </edited>
 namespace Ordisoftware.Hebrew.Calendar;
 
-partial class SearchEventForm : Form
+sealed partial class SearchEventForm : Form
 {
 
   private readonly MainForm MainForm = MainForm.Instance;

diff --git a/Project/Source/Forms/Boxes/Search/SearchGregorianMonthForm.cs b/Project/Source/Forms/Boxes/Search/SearchGregorianMonthForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-11 </edited>
 namespace Ordisoftware.Hebrew.Calendar;
 
-partial class SearchGregorianMonthForm : Form
+sealed partial class SearchGregorianMonthForm : Form
 {
 
   private readonly MainForm MainForm = MainForm.Instance;

diff --git a/Project/Source/Forms/Boxes/Search/SearchLunarMonthForm.cs b/Project/Source/Forms/Boxes/Search/SearchLunarMonthForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-11 </edited>
 namespace Ordisoftware.Hebrew.Calendar;
 
-partial class SearchLunarMonthForm : Form
+sealed partial class SearchLunarMonthForm : Form
 {
 
   private readonly MainForm MainForm = MainForm.Instance;

diff --git a/Project/Source/Forms/Boxes/Select/SelectCityForm.cs b/Project/Source/Forms/Boxes/Select/SelectCityForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2023-01 </edited>
 namespace Ordisoftware.Hebrew.Calendar;
 
-partial class SelectCityForm : Form
+sealed partial class SelectCityForm : Form
 {
 
   static private readonly Properties.Settings Settings = Program.Settings;

diff --git a/Project/Source/Forms/Boxes/Select/SelectExportTargetForm.cs b/Project/Source/Forms/Boxes/Select/SelectExportTargetForm.cs
@@ -16,7 +16,7 @@ namespace Ordisoftware.Hebrew.Calendar;
 
 using MoreLinq;
 
-partial class SelectExportTargetForm : Form
+sealed partial class SelectExportTargetForm : Form
 {
 
   static private readonly Properties.Settings Settings = Program.Settings;

diff --git a/Project/Source/Forms/Boxes/Tools/ManageAcquaintanceEventsForm.cs b/Project/Source/Forms/Boxes/Tools/ManageAcquaintanceEventsForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-01 </edited>
 namespace Ordisoftware.Hebrew.Calendar;
 
-partial class ManageAcquaintanceEventsForm : Form
+sealed partial class ManageAcquaintanceEventsForm : Form
 {
 
   //private const string TableName = "Date Bookmarks";

diff --git a/Project/Source/Forms/Boxes/Tools/ManageBookmarksForm.Save.cs b/Project/Source/Forms/Boxes/Tools/ManageBookmarksForm.Save.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-11 </edited>
 namespace Ordisoftware.Hebrew.Calendar;
 
-sealed partial class ManageBookmarksForm : Form
+partial class ManageBookmarksForm : Form
 {
 
   private const string TableName = "Date Bookmarks";

diff --git a/Project/Source/Forms/Boxes/Tools/ManageBookmarksForm.cs b/Project/Source/Forms/Boxes/Tools/ManageBookmarksForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-08 </edited>
 namespace Ordisoftware.Hebrew.Calendar;
 
-partial class ManageBookmarksForm : Form
+sealed partial class ManageBookmarksForm : Form
 {
 
   static private readonly Properties.Settings Settings = Program.Settings;

diff --git a/Project/Source/Forms/Boxes/Tools/NavigationForm.cs b/Project/Source/Forms/Boxes/Tools/NavigationForm.cs
@@ -14,7 +14,7 @@
 /// <edited> 2022-11 </edited>
 namespace Ordisoftware.Hebrew.Calendar;
 
-partial class NavigationForm : Form
+sealed partial class NavigationForm : Form
 {
 
   private const string NoDataField = "-";

diff --git a/Project/Source/Forms/Config/PreferencesForm.Initialize.cs b/Project/Source/Forms/Config/PreferencesForm.Initialize.cs
@@ -22,7 +22,7 @@ namespace Ordisoftware.Hebrew.Calendar;
 /// </summary>
 /// <seealso cref="T:System.Windows.Forms.Form"/>
 [SuppressMessage("CodeQuality", "IDE0052:Supprimer les membres privés non lus", Justification = "N/A")]
-sealed partial class PreferencesForm
+partial class PreferencesForm
 {
 
   private sealed class LayoutSectionItem

diff --git a/Project/Source/Forms/Config/PreferencesForm.cs b/Project/Source/Forms/Config/PreferencesForm.cs
@@ -21,7 +21,7 @@ namespace Ordisoftware.Hebrew.Calendar;
 /// Provides form to edit the preferences.
 /// </summary>
 /// <seealso cref="T:System.Windows.Forms.Form"/>
-partial class PreferencesForm : Form
+sealed partial class PreferencesForm : Form
 {
 
   #region Variables

diff --git a/README.md b/README.md
@@ -376,6 +376,7 @@ It is therefore possible to use [AutoHotKey](https://www.autohotkey.com) to defi
 
 #### TO DO Next
 
+>- Add previous and next buttons to parashah description box.
 >- Add lunar months board with Hebrew names, meanings, lettriqs and tools.
 >- Add command-line option `--lunarmonths` to show the lunar months board.
 >- Add comments to bookmarks.