Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested Minor Changes #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Suggested Minor Changes #15

wants to merge 1 commit into from

Conversation

pcrumley
Copy link

Hi!

Apologies for just opening a PR without talking to you first, but I found your crate useful and I had a few minor changes i thought you wouldn't mind taking.

  1. you don't need a mutable reference to Parts when you extract the headers
  2. It's a good idea to remove passwords from the debug implementation of auth structs.

If you don't like my suggestions, feel free not to merge them in.

patrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pcrumley