(Fixes #315) Exclude lighty.io core logging dependencies #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lighty-parent is adding logging dependencies like log4j which is conflicting with lighty.io validator logic depending on logback (and hard-casting to it). Use lighty-minimal-parent instead which just declares needed lighty.io core and OpenDaylight dependencies. There is planned effort which will bring maven.compiler.release to lighty-minimal-parent in lighty.io 22. This is marked by FIXME. JIRA: LIGHTY-350 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
ihrasko
force-pushed
the
exclude-log4j
branch
from
51662ea to
1f29bb8
Compare
ihrasko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lighty-parent is adding logging dependencies like log4j which is conflicting with lighty.io validator logic depending on logback (and hard-casting to it).
Use lighty-minimal-parent instead which just declares needed lighty.io core and OpenDaylight dependencies.
JIRA: LIGHTY-350