Institution issue debug #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having looked again though, I don't think the issue is in the Python (my bad). I think it's the line As far as I can tell, bash then tries to echo the string, but explodes because all the special characters (brackets, single quotes etc.) aren't escaped by |
|
Ok, what I think is a fix is now pushed. |
|
This is now handled in the scripts of the WCRP-CMIP/CMIP-LD library. These have been rewritten from scratch so hoping that this was fixed. Closing for now, but if it still persists, I will reopen it as part of that repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the discussion in #57 (specifically this comment #57 (comment)).
@wolfiex I couldn't do a full debug because the payload shown by GitHub doesn't seem to match what Python is seeing so I couldn't figure out what exactly Python had to handle/how to test this (although I could be missing something and I didn't want to try and do a full reproduction of GitHub workflows locally).
The changes here would help with debugging I suspect, without interfering with the successful path.