Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(go): polishing #243

Merged
merged 6 commits into from
Sep 26, 2024
Merged

refactor(go): polishing #243

merged 6 commits into from
Sep 26, 2024

Conversation

rkettelerij
Copy link
Collaborator

@rkettelerij rkettelerij commented Sep 25, 2024

Description

Moved a variable, split a func and an extra test. Removed potential flaky test (map order).

Type of change

  • Refactoring

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

@rkettelerij rkettelerij merged commit b1ec680 into master Sep 26, 2024
5 checks passed
@rkettelerij rkettelerij deleted the refactoring branch September 26, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants