Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for OGC API Tiles validator findings [merge in januari] #267

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Fixes for OGC API Tiles validator findings [merge in januari] #267

wants to merge 20 commits into from

Conversation

kad-korpem
Copy link
Collaborator

@kad-korpem kad-korpem commented Dec 17, 2024 •
edited
Loading

Description

  • Add tileMatrixSetLimits to /tiles
  • Add tileMatrixSetURI to /tiles for registered TileMatrixSets
  • Correct operationId suffixes in /api
  • Return HTTP 404 instead of HTTP 204 on out of bounds requests
  • Add e2e-test for OGC API Tiles conformance

Type of change

(Remove irrelevant options)

  • New feature
  • Improvement of existing feature
  • Bugfix
  • Refactoring

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

rkettelerij
rkettelerij reviewed Dec 18, 2024
View reviewed changes
internal/engine/templates/openapi/tiles.go.json Outdated Show resolved Hide resolved
internal/engine/templates/openapi/tiles.go.json Outdated Show resolved Hide resolved
internal/engine/templates/openapi/tiles.go.json Outdated Show resolved Hide resolved
internal/engine/templates/openapi/tiles.go.json Outdated Show resolved Hide resolved
internal/engine/templates/openapi/tiles.go.json Outdated Show resolved Hide resolved
rkettelerij
rkettelerij approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@rkettelerij rkettelerij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mooi werk, paar comments

internal/ogc/tiles/main.go Outdated Show resolved Hide resolved
internal/ogc/tiles/main_test.go Show resolved Hide resolved
@rkettelerij rkettelerij marked this pull request as draft December 18, 2024 14:48
@rkettelerij rkettelerij changed the title Fixes for OGC API Tiles validator findings Fixes for OGC API Tiles validator findings [merge in januari] Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkettelerij rkettelerij rkettelerij approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kad-korpem @rkettelerij