added support for array of output objects. #8
Conversation
| @@ -1,2 +1,5 @@ | |||
| @attached(peer, names: arbitrary) | |||
| public macro Parametrize<T>(input: [T]) = #externalMacro(module: "XCTestParametrizedMacroMacros", type: "ParametrizeMacro") | |||
There was a problem hiding this comment.
While we're introducing generic param names for Input and Output we could also change it for original single Input so change from T to I for clarity. But it can be also done in the future cleanup/refactor so moving on.
| var outputValues: ArrayElementListSyntax? { | ||
| get throws { | ||
| guard let firstMacroArgument = firstAttribute?.arguments?.as(LabeledExprListSyntax.self) else { | ||
| throw ParametrizeMacroError.macroAttributeNotAnArray |
There was a problem hiding this comment.
I think we need to generalize the error message for this. Right now it mentions input only so it should be something like input/output. Another possibility is to introduce separate dedicated errors for input and output.
There was a problem hiding this comment.
for now I've changed only text to make the message more generic
| @@ -6,6 +6,7 @@ enum ParametrizeMacroError: Error, CustomStringConvertible { | |||
| case functionInputParamTypeMissing | |||
| case functionBodyEmpty | |||
| case macroAttributeNotAnArray | |||
| case macroAttributeMismatchSizeInputOutputArray | |||
There was a problem hiding this comment.
Maybe we should simplify the naming here. It's related to my previous comment about using macroAttributeNotAnArray error.
It could be something like macroAttributeArraysMismatchSize. This way we will not be forced to rename it in the future when implementing a proposal from the #9.
| @@ -270,4 +270,31 @@ final class SimpleValuesTests: XCTestCase { | |||
| macros: testMacros | |||
| ) | |||
| } | |||
|
|
|||
| func testParametrizeInputOutput_SingleObject() throws { | |||
There was a problem hiding this comment.
It's rather single Int so we should change the test name for clarity.
There was a problem hiding this comment.
also removed one duplicated test from other class.
Added support for array of output objects #5