Improved tests for issue #893

PHPSocialNetwork · Feb 18, 2023 · 8614c56 · 8614c56
1 parent 05bd124
commit 8614c56
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/lib/Phpfastcache/Core/Pool/TaggableCacheItemPoolTrait.php b/lib/Phpfastcache/Core/Pool/TaggableCacheItemPoolTrait.php
@@ -410,10 +410,6 @@ protected function driverWriteTags(ExtendedCacheItemInterface $item): bool
             $data = \array_merge((array)$data, [$item->getKey() => $expTimestamp]);
             $tagsItem->set($data);
 
-            if (!$tagsItem->isHit() || $tagsItem->getExpirationDate() < $item->getExpirationDate()) {
-                $tagsItem->expiresAt($item->getExpirationDate());
-            }
-
             /**
              * Recalculate the expiration date
              *

diff --git a/tests/issues/Github-893.test.php b/tests/issues/Github-893.test.php
@@ -35,6 +35,13 @@
     $cacheInstance->save($CachedString2);
 }
 
+$CachedString3 = $cacheInstance->getItem("key_3");
+if (is_null($CachedString3->get())) {
+    $CachedString3->set("data3")->expiresAfter(4);
+    $CachedString3->addTag("query");
+    $cacheInstance->save($CachedString3);
+}
+
 $cacheInstance->detachAllItems();
 $testHelper->printInfoText('Items created and saved, sleeping 6 secondes to force "key_1" to expire');
 sleep(6);