Fixed infinite loop with extensions + added help in Exception

PHPSocialNetwork · Jan 4, 2024 · fd6221c · fd6221c
1 parent 8ad5ce0
commit fd6221c
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 5 deletions.
diff --git a/lib/Phpfastcache/CacheManager.php b/lib/Phpfastcache/CacheManager.php
@@ -313,7 +313,6 @@ public static function getDriverList(bool $fqcnAsKey = false): array
 
         if (self::getDefaultNamespacePath() === self::getNamespacePath()) {
             if ($driverList === null) {
-                ExtensionManager::autoloadExtensions();
                 $prefix = self::CORE_DRIVER_NAMESPACE;
                 $classMap = self::createClassMap(__DIR__ . '/Drivers');
                 $driverList = [];

diff --git a/lib/Phpfastcache/Core/Pool/DriverBaseTrait.php b/lib/Phpfastcache/Core/Pool/DriverBaseTrait.php
@@ -77,7 +77,13 @@ public function __construct(#[\SensitiveParameter] ConfigurationOptionInterface
         $this->instanceId = $instanceId;
 
         if (!$this->driverCheck()) {
-            throw new PhpfastcacheDriverCheckException(\sprintf(ExtendedCacheItemPoolInterface::DRIVER_CHECK_FAILURE, $this->getDriverName()));
+            throw new PhpfastcacheDriverCheckException(
+                \sprintf(
+                    ExtendedCacheItemPoolInterface::DRIVER_CHECK_FAILURE,
+                    $this->getDriverName(),
+                    $this->getHelp() ? " Additionally, {$this->getHelp()}" : ''
+                )
+            );
         }
         $this->eventManager->dispatch(Event::CACHE_DRIVER_CHECKED, $this);
 
@@ -92,7 +98,7 @@ public function __construct(#[\SensitiveParameter] ConfigurationOptionInterface
                     $this->getDriverName(),
                     $e->getMessage(),
                     $e->getLine() ?: 'unknown line',
-                    $e->getFile() ?: 'unknown file'
+                    $e->getFile() ?: 'unknown file',
                 ),
                 0,
                 $e

diff --git a/lib/Phpfastcache/Core/Pool/ExtendedCacheItemPoolInterface.php b/lib/Phpfastcache/Core/Pool/ExtendedCacheItemPoolInterface.php
@@ -37,9 +37,9 @@
 interface ExtendedCacheItemPoolInterface extends CacheItemPoolInterface, EventManagerDispatcherInterface, ClassNamespaceResolverInterface, TaggableCacheItemPoolInterface
 {
     public const DRIVER_CHECK_FAILURE = '%s is not installed or is misconfigured, cannot continue. 
-    Also, please verify the suggested dependencies in composer because as of the V6, 3rd party libraries are no longer required.';
+    Also, please verify the suggested dependencies in composer because as of the V6, 3rd party libraries are no longer required.%s';
 
-    public const DRIVER_CONNECT_FAILURE = '%s failed to connect with the following error message: "%s" line %d in %s';
+    public const DRIVER_CONNECT_FAILURE = '%s failed to connect with the following error message: "%s" line %d in %s.';
 
     public const DRIVER_KEY_WRAPPER_INDEX = 'k';
 

diff --git a/lib/Phpfastcache/Drivers/Wincache/Driver.php b/lib/Phpfastcache/Drivers/Wincache/Driver.php
@@ -40,6 +40,13 @@ public function driverCheck(): bool
         return extension_loaded('wincache') && function_exists('wincache_ucache_set');
     }
 
+    public function getHelp(): string
+    {
+        return <<<HELP
+Wincache PECL extension is not maintained anymore and has been superseded. Check sourceforge for more informations: https://sourceforge.net/projects/wincache/'
+HELP;
+    }
+
     /**
      * @return DriverStatistic
      */

diff --git a/tests/Wincache.test.php b/tests/Wincache.test.php
@@ -0,0 +1,28 @@
+<?php
+
+/**
+ *
+ * This file is part of Phpfastcache.
+ *
+ * @license MIT License (MIT)
+ *
+ * For full copyright and license information, please see the docs/CREDITS.txt and LICENCE files.
+ *
+ * @author Georges.L (Geolim4)  <contact@geolim4.com>
+ * @author Contributors  https://github.com/PHPSocialNetwork/phpfastcache/graphs/contributors
+ */
+
+use Phpfastcache\CacheManager;
+use Phpfastcache\Exceptions\PhpfastcacheDriverCheckException;
+use Phpfastcache\Tests\Helper\TestHelper;
+use Phpfastcache\Drivers\Wincache\Config as WincacheConfig;
+use Redis as RedisClient;
+
+chdir(__DIR__);
+require_once __DIR__ . '/../vendor/autoload.php';
+$testHelper = new TestHelper('Wincache');
+
+$cacheInstance = CacheManager::getInstance('Wincache', new WincacheConfig());
+$testHelper->runCRUDTests($cacheInstance);
+
+$testHelper->terminateTest();