Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weights_scale attribute to the Records and Data classes #2828

Merged
merged 7 commits into from
Oct 27, 2024

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Oct 25, 2024

Provides flexibility in converting weights in the *_weights.csv.gz files into s006 values.

This flexibility is essential when using tax-microdata area weights as described in TMD PR #264.

@martinholmer martinholmer marked this pull request as draft October 25, 2024 17:54
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (cfca1d5) to head (163d040).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2828   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2615     2616    +1     
=======================================
+ Hits         2600     2601    +1     
  Misses         15       15           
Flag Coverage Δ
unittests 99.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
taxcalc/__init__.py 100.00% <100.00%> (ø)
taxcalc/data.py 99.25% <100.00%> (+<0.01%) ⬆️
taxcalc/records.py 100.00% <100.00%> (ø)
taxcalc/taxcalcio.py 100.00% <100.00%> (ø)

@martinholmer martinholmer marked this pull request as ready for review October 27, 2024 19:46
@martinholmer martinholmer merged commit a559002 into PSLmodels:master Oct 27, 2024
9 checks passed
@martinholmer martinholmer deleted the tmd-weights-scaling branch October 27, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant