Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weights precision in CLI tool default micro output file #2841

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Nov 18, 2024

When using neither the tc tmd.csv ... --dump option nor the tc tmd.csv ... --sqldb option, the weights in the micro output file were being incorrectly rounded to two (rather than five) decimal digits. This PR fixes that problem. There is no change in tc tmd.csv ... micro output when using either the --dump option or the --sqldb option (that is, the weights precision remains five digits after the decimal point).

@martinholmer martinholmer changed the title Fix weights precision in default CLI tool output file Fix weights precision in CLI tool default micro output file Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (b3bca61) to head (8542516).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2841   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2617     2619    +2     
=======================================
+ Hits         2602     2604    +2     
  Misses         15       15           
Flag Coverage Δ
unittests 99.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
taxcalc/taxcalcio.py 100.00% <100.00%> (ø)
---- 🚨 Try these New Features:

@martinholmer martinholmer merged commit ed27836 into PSLmodels:master Nov 18, 2024
9 checks passed
@martinholmer martinholmer deleted the fix-tc-csv-weights branch November 18, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant