Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] user, cs domain 주석 추가 #171

Merged
merged 2 commits into from
Sep 13, 2023
Merged

[refactor] user, cs domain 주석 추가 #171

merged 2 commits into from
Sep 13, 2023

Conversation

chaerlo127
Copy link
Collaborator

🌱 이슈 번호

close #170


💬 기타 사항

  • 주석 처리 진행하면서 프로필 수정의 프로필 이미지 variable 이름을 profileImgUrl -> imgUrl로 변경햇습니다
  • 프로필 수정 API 가 post method로 되어 있어, patch로 변경햇습니다 (제 실수,,ㅎㅅㅎ,,)

@chaerlo127 chaerlo127 added 🐣 chae-eun 채은이가 만든 기능이에요 ! 🎀 chore 간단한 오타 등의 코드를 수정해요 ! 🌿 refactor 코드 구조를 변경해요 ! 👩🏻‍💻 users 사용자 도메인 기능이에요 ! 👥 cs cs 도메인 기능이에요 ! labels Sep 12, 2023
@chaerlo127 chaerlo127 self-assigned this Sep 12, 2023
sojungpp
sojungpp approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@sojungpp sojungpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🥳

@chaerlo127 chaerlo127 merged commit 8021da0 into develop Sep 13, 2023
1 check passed
@sojungpp sojungpp deleted the refactor/#170-writeComments branch October 21, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psyeon1120 psyeon1120 psyeon1120 approved these changes

@sojungpp sojungpp sojungpp approved these changes

Assignees

@chaerlo127 chaerlo127

Labels
🐣 chae-eun 채은이가 만든 기능이에요 ! 🎀 chore 간단한 오타 등의 코드를 수정해요 ! 👥 cs cs 도메인 기능이에요 ! 🌿 refactor 코드 구조를 변경해요 ! 👩🏻‍💻 users 사용자 도메인 기능이에요 !
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refactor] user, cs 도메인 주석 추가
3 participants
@chaerlo127 @psyeon1120 @sojungpp