fix Windows Build (#10)

- Fix portability of vector iterator - Fix casting to HANDLE
PX4 · Aug 19, 2024 · 70c8256 · 70c8256
1 parent 4d468f9
commit 70c8256
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/ulog_cpp/messages.cpp b/ulog_cpp/messages.cpp
@@ -278,7 +278,7 @@ Value::NativeTypeVariant Value::asNativeTypeVariant() const
         if (_backing_ref_end - string_start_iterator < _field_ref.arrayLength()) {
           throw AccessException("Decoding fault, memory too short");
         }
-        int string_length = strnlen(string_start_iterator.base(), _field_ref.arrayLength());
+        const int string_length = strnlen(&(*string_start_iterator), _field_ref.arrayLength());
         return std::string(string_start_iterator, string_start_iterator + string_length);
       }
 

diff --git a/ulog_cpp/simple_writer.cpp b/ulog_cpp/simple_writer.cpp
@@ -5,7 +5,8 @@
 
 #include "simple_writer.hpp"
 
-#ifdef WINDOWS
+#ifdef _WIN32
+#include <windows.h> // NOLINT
 #include <fileapi.h>
 #else
 #include <unistd.h>
@@ -112,8 +113,8 @@ void SimpleWriter::fsync()
 {
   if (_file) {
     fflush(_file);
-#ifdef WINDOWS
-    FlushFileBuffers(static_cast<HANDLE>(_fileno(_file)));
+#ifdef _WIN32
+    FlushFileBuffers(reinterpret_cast<HANDLE>(static_cast<uintptr_t>(_fileno(_file))));
 #else
     ::fsync(fileno(_file));
 #endif