read-api: Fix cppcheck errors

PX4 · Sep 26, 2023 · d63af38 · d63af38
1 parent 2cf4a07
commit d63af38
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/ulog_cpp/messages.cpp b/ulog_cpp/messages.cpp
@@ -311,21 +311,19 @@ MessageInfo::MessageInfo(Field field, std::vector<uint8_t> value, bool is_multi,
     : _field(std::move(field)), _value(std::move(value)), _continued(continued), _is_multi(is_multi)
 {
 }
-MessageInfo::MessageInfo(const std::string& key, int32_t value)
+MessageInfo::MessageInfo(const std::string& key, int32_t value) : _field({"int32_t", key})
 {
-  _field = {"int32_t", key};
   _value.resize(sizeof(value));
   memcpy(_value.data(), &value, sizeof(value));
 }
-MessageInfo::MessageInfo(const std::string& key, float value)
+MessageInfo::MessageInfo(const std::string& key, float value) : _field({"float", key})
 {
-  _field = {"float", key};
   _value.resize(sizeof(value));
   memcpy(_value.data(), &value, sizeof(value));
 }
 MessageInfo::MessageInfo(const std::string& key, const std::string& value)
+    : _field({"char", key, static_cast<int>(value.length())})
 {
-  _field = {"char", key, static_cast<int>(value.length())};
   _value.resize(value.length());
   memcpy(_value.data(), value.data(), value.length());
 }

diff --git a/ulog_cpp/messages.hpp b/ulog_cpp/messages.hpp
@@ -341,8 +341,8 @@ class MessageFormat {
   std::vector<std::string> fieldNames() const
   {
     std::vector<std::string> names;
-    for (auto& field : _fields_ordered) {
-      names.push_back(field->name());
+    for (const auto& field_it : _fields_ordered) {
+      names.push_back(field_it->name());
     }
     return names;
   }