fix bug where if hash number is 100, fails to match variant that is 100

PabloJoan · Nov 28, 2023 · 3ecbeb4 · 3ecbeb4
1 parent b8d5558
commit 3ecbeb4
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/Configurations/Config.php b/src/Configurations/Config.php
@@ -35,12 +35,16 @@ public function pickVariantOutOfHat(string $id): string
     {
         $hashOrRandomNumber = $this->bucketing->strToIntHash($id);
 
-        $variant = key(array_filter(
-            $this->variantIntegerRanges,
-            fn (int $variantRange): bool => $hashOrRandomNumber < $variantRange
-        ));
+        foreach ($this->variantIntegerRanges as $variant => $variantRange) {
+            if ($hashOrRandomNumber < $variantRange) {
+                return $variant;
+            }
+            if ($hashOrRandomNumber === 100 && $variantRange === 100) {
+                return $variant;
+            }
+        }
 
-        return $variant ?? '';
+        return '';
     }
 
     /**