Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][Typos][N-[1-5]] Fix typos(namess, nams, neccessary, Neet, neet, neeed, nedd) #70278

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yinfan98
Copy link
Contributor

@yinfan98 yinfan98 commented Dec 17, 2024

PR Category

User Experience

PR Types

Improvements

Description

Fix Typos~ (这几个改的大部分都是注释orz
N1-N5
namess->names
nams->names
neccessary->necessary
{Neet, neet, neeed, nedd}->need

@yinfan98 yinfan98 requested a review from SigureMo as a code owner December 17, 2024 11:15
Copy link

paddle-bot bot commented Dec 17, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 17, 2024
@SigureMo SigureMo changed the title [CodeStyle][Typos][N-[1-5]] Fix typos(namess ,nams ,neccessary ,Neet ,neet ,neeed ,nedd ) [CodeStyle][Typos][N-[1-5]] Fix typos(namess, nams, neccessary, Neet, neet, neeed, nedd) Dec 17, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo
Copy link
Member

冲突了

@SigureMo
Copy link
Member

这个和 #70283 是不是还会再冲突一次?可以考虑把配置修改集中在一个文件避免冲突,PR 描述里说一下就好了,比如这个 PR 不修改配置,统一在 #70283

@yinfan98
Copy link
Contributor Author

这个和 #70283 是不是还会再冲突一次?可以考虑把配置修改集中在一个文件避免冲突,PR 描述里说一下就好了,比如这个 PR 不修改配置,统一在 #70283

了解了

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants